search

apavlidi / IT_API

The Internet services of the IT department of Alexander Technological Education Institute of Thessaloniki
http://api.it.teithe.gr/
MIT License
14 stars 5 forks source link

Add the .gitignore file #68

Closed dpliakos closed 5 years ago

dpliakos commented 5 years ago

I added a .gitignore file (helps a lot) and run update and audit fix commands.

apavlidi commented 5 years ago

Hey @dPliakos thank you for the PR! 👍

Did you install and run the application to check if any errors introduced by updating the libraries? Some of the libraries such as log4js changed its API so by updating the library the code breaks. So either we update certain libraries that are backward compatible, or we update them all (just like you did) and we make some changes on certain areas of the code with the new APIs. The .gitignore file is necessary and thanks for pointing that out, I am really suprised we didn`t have one.

dpliakos commented 5 years ago

I have problems with my virtual box installation. I was hopping to have that fixed before the review. Can you validate it? If not, let me just remove the update commits until I fix my setup.

apavlidi commented 5 years ago

I can help you with the installation process if you want, just head to the slack channel and PM me so we can tackle the problem together. I don't have to validate cause I know log4js for sure changed its API so we can't update this library without updating the code.

dpliakos commented 5 years ago

Thanks! I'm sending you at slack

dpliakos commented 5 years ago

A removed the updates, for now. I will do another PR for the updates.