search

apavlidi / IT_API

The Internet services of the IT department of Alexander Technological Education Institute of Thessaloniki
http://api.it.teithe.gr/
MIT License
14 stars 5 forks source link

We need to translate every message in eng #7

Open apavlidi opened 6 years ago

iamaldi commented 5 years ago

What exactly needs to be done here? Which messages need to be translated?

Thanks Aldi

apavlidi commented 5 years ago

Every response message that is returned from the API needs to be in English and not in Greek. for example here https://github.com/apavlidi/IT_API/blob/aa3492d589ef1c2abf7828708a53f6e210872c23/routes/bulletinBoard/announcements/index.js#L51 One solution may be a hard code change with English text. Another solution may be with i18n npm module which supports multilingual.

iamaldi commented 5 years ago

I would suggest a separate file in which there are written all the required messages. Then you can include that file wherever its needed thus removing the unwanted duplication that yiu want to achieve. Since all messages seem to be custom, a separate file looks like a good alternative. Please let me know what are your thoughts on that.

From: Alexis Pavlidis notifications@github.com Sent: Saturday, December 1, 2018 10:32:38 PM To: apavlidi/IT_API Cc: Aldi; Comment Subject: Re: [apavlidi/IT_API] We need to translate every message in eng (#7)

Every response message that is returned from the API needs to be in English and not in Greek. for example here https://github.com/apavlidi/IT_API/blob/aa3492d589ef1c2abf7828708a53f6e210872c23/routes/bulletinBoard/announcements/index.js#L51 One solution may be a hard code change with English text. Another solution may be with i18n npm module which supports multilingual.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/apavlidi/IT_API/issues/7#issuecomment-443456316, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVyUbpTTaYWWcjHoacg2pFTW2BdZs3iNks5u0udmgaJpZM4VRA9b.

apavlidi commented 5 years ago

This is the way to go actually. The i18n npm module supports that and I would recommend using it as I used in the past and solved the language issue.