apax-hub / apax

A flexible and performant framework for training machine learning potentials.
MIT License
15 stars 2 forks source link

Rename `opt_name` to `name` #274

Closed PythonFZ closed 2 months ago

PythonFZ commented 5 months ago

https://github.com/apax-hub/apax/blob/13142e1138a61bc2752a274aea704c498a726ab9/apax/config/train_config.py#L228-L236

I suggest going from:

optimizer:
  opt_name: adam
  opt_kwargs: ...
  emb_lr: 0.01
  nn_lr: 0.005
  scale_lr: 0.001
  shift_lr: 0.05
  zbl_lr: 0.001

to

optimizer:
  name: adam
  kwargs: ...
  emb_lr: 0.01
  nn_lr: 0.005
  scale_lr: 0.001
  shift_lr: 0.05
  zbl_lr: 0.001

to remove redundant information

M-R-Schaefer commented 5 months ago

good point!

M-R-Schaefer commented 2 months ago

fixed in v0.5.0