Installation failure on WSL2 Ubuntu 22.04 with gcc and gfortran 11.3

taiyi10086 commented 1 year ago

I failed to install CERNLIB of this version on WSL2 Ubuntu 22.04 with gcc and gfortran 11.3. The compilation is aborted with these two kinds of messages:

(1) Error of sys_errlist /cernlib-master/2006/src/packlib/kernlib/kernbit/z268/systems.c:137:59: error: ‘sys_errlist’ undeclared (first use in this function) /cernlib-master/2006/src/packlib/cspack/sysreq/serror.c:180:32: error: ‘sys_errlist’ undeclared (first use in this function) /cernlib-master/2006/src/packlib/cspack/sysreq/socket.c:415:16: error: ‘sys_errlist’ undeclared (first use in this function)

(2) Error of sys_nerr /cernlib-master/2006/src/packlib/cspack/sysreq/serror.c:179:33: error: ‘sys_nerr’ undeclared (first use in this functions)

I have successfully installed this CERNLIB on Ubuntu 18.04 with gcc 7.5.

It seems that the installation failure on Ubuntu 22.04 is resulted from the changes in the update of GNU compiler.

In addition, although the flag -fallow-invalid-boz has been added, there are still some problems caused by using nonstandard X instead of Z for Hexadecimal constant. I have to change X to Z manually.

dmikushin commented 1 year ago

Hi @taiyi10086 thank you very much for your report. Could you please share a patch/diff showing how you have changed X to Z?

Yes, older gfortran compilers are usually more "permissive" wrt language dialects. But we should improve the code and keep it compatible.

taiyi10086 commented 1 year ago

Hey @dmikushin , I use ./build64 2006 to install CERNLIB, so that I had only changed the files in /2006/src. 7 files should be modified as showing below by diff:

diff -r cernlib-master/2006/src/packlib/cspack/xz/xzctof.F cernlib-master-modified/2006/src/packlib/cspack/xz/xzctof.F
40c40
       DATA         IPATT/X'0123CDEF'/
       DATA         IPATT/Z'0123CDEF'/
diff -r cernlib-master/2006/src/packlib/cspack/xz/xzftoc.F cernlib-master-modified/2006/src/packlib/cspack/xz/xzftoc.F
40c40
       DATA         IPATT/X'0123CDEF'/
       DATA         IPATT/Z'0123CDEF'/
diff -r cernlib-master/2006/src/packlib/cspack/xz/xzfzcp.F cernlib-master-modified/2006/src/packlib/cspack/xz/xzfzcp.F
53c53
       DATA         IPATT/X'0123CDEF'/
       DATA         IPATT/Z'0123CDEF'/
diff -r cernlib-master/2006/src/packlib/cspack/xz/xzputf.F cernlib-master-modified/2006/src/packlib/cspack/xz/xzputf.F
53c53
       DATA         IPATT/X'0123CDEF'/
       DATA         IPATT/Z'0123CDEF'/
diff -r cernlib-master/2006/src/packlib/cspack/xz/xzrfrf.F cernlib-master-modified/2006/src/packlib/cspack/xz/xzrfrf.F
58c58
       DATA         IPATT/X'0123CDEF'/
       DATA         IPATT/Z'0123CDEF'/
diff -r cernlib-master/2006/src/packlib/kernlib/kerngen/tcgens/lnxgs/ublow.F cernlib-master-modified/2006/src/packlib/kernlib/kerngen/tcgens/lnxgs/ublow.F
19,20c19,20
       data iblan1/x'20202000'/
       data mask1/x'000000ff'/
       data iblan1/Z'20202000'/
       data mask1/Z'000000ff'/
diff -r cernlib-master/2006/src/packlib/kernlib/kerngen/tcgens/lnxgs/ubunch.F cernlib-master-modified/2006/src/packlib/kernlib/kerngen/tcgens/lnxgs/ubunch.F
19,20c19,20
       data iblan1/x'20202020'/
       data mask1/x'000000ff'/
       data iblan1/Z'20202020'/
       data mask1/Z'000000ff'/

cernlib-master contains the original files and cernlib-master-modified contains the modified files.

Note: the symbols "<", ">" and "---" are removed from the above text as they leads to a strange display.

taiyi10086 commented 1 year ago

Finally, I installed WSL2 Ubuntu 20.04 and therefore the CERNLIB was correctly installed The gcc version is 9.4.0

I suggest that use /bin/bash rather than /bin/sh in build64. /bin/sh will result in some problems about PATH, while /bin/bash does not.