apcshields / autocomplete-bibtex

Adds Pandoc-style BibTeX citation key autocompletion to autocomplete+ for Atom.
MIT License
44 stars 17 forks source link

#24 Add search UI #42

Closed mangecoeur closed 8 years ago

mangecoeur commented 9 years ago

Addresses #24 - adds a simple model to allow searching through bibliography, hit enter to insert citekey. Adds corresponding command, and also a command to force reload your bib file

tpoisot commented 9 years ago

I really like the idea -- but we just added support for citeproc json and yaml files in addition to bibtex, so you'll need to rebase.

mangecoeur commented 9 years ago

ok will do

tpoisot commented 9 years ago

:+1: -- Your Citer package was one of the things that made it hard to leave SublimeText behind, by the way.

apcshields commented 8 years ago

@mangecoeur It doesn't look like you've rebased and updated the pull request. Are you ready to do that?

Thanks!

mangecoeur commented 8 years ago

So I did the rebase for the search view, along with some cosmetic changes. I did see some issues with styles that should have been inherited from SelectListView but weren't but I wasn't able to work around that, it could be a problem only on my end though so please have a look and see...

mangecoeur commented 8 years ago

P.s. let me know if you are ready to merge the PR

apcshields commented 8 years ago

@mangecoeur,

I'm hoping to make some time to work on it tomorrow. Is that ok?

Andrew

— Sent from Mailbox

On Thu, Nov 19, 2015 at 6:25 AM, mangecoeur notifications@github.com wrote:

P.s. let me know if you are ready to merge the PR

Reply to this email directly or view it on GitHub: https://github.com/apcshields/autocomplete-bibtex/pull/42#issuecomment-158028158

mangecoeur commented 8 years ago

Sure no problem On 19 Nov 2015 12:09 pm, "apcshields" notifications@github.com wrote:

@mangecoeur,

I'm hoping to make some time to work on it tomorrow. Is that ok?

Andrew

— Sent from Mailbox

On Thu, Nov 19, 2015 at 6:25 AM, mangecoeur notifications@github.com wrote:

P.s. let me know if you are ready to merge the PR

Reply to this email directly or view it on GitHub:

https://github.com/apcshields/autocomplete-bibtex/pull/42#issuecomment-158028158

— Reply to this email directly or view it on GitHub https://github.com/apcshields/autocomplete-bibtex/pull/42#issuecomment-158038268 .