search

apearson / southern-company-api

Node.js Library to access utility data from Southern Company power utilities (Alabama Power, Georgia Power, Mississippi Power)
BSD 3-Clause "New" or "Revised" License
40 stars 7 forks source link

dev-containers support #124

Closed vsoneji closed 9 months ago

vsoneji commented 10 months ago

Two convenience changes:

  1. Ability to develop inside a dev-container with VS-Code.
  2. Transitioned away from the defunct tslint to the new eslint.

Dev Containers

see Developing inside a Container section Quick start: Open a Git repository or GitHub PR in an isolated container volume is quite useful

Also Resolving Git line ending issues in containers (resulting in many modified files) talks about the .gitattributes file.

ES-Lint

tslint-to-eslint-config is a simple tool that helps users convert from tslint to eslint

apearson commented 9 months ago

This all looks good, thank you! I'm going to do a couple final checks and merge soon

apearson commented 9 months ago

Dev Container Looks good & ESLint looks good.

Merging

vsoneji commented 9 months ago

You are very welcome. Thank you for your work. Also, apologies for the late response, I was traveling and didn't get a chance to see the notifications.