apearson / southern-company-api

Node.js Library to access utility data from Southern Company power utilities (Alabama Power, Georgia Power, Mississippi Power)
BSD 3-Clause "New" or "Revised" License
40 stars 7 forks source link

Usage no longer takes "AccountNumber" #55

Closed Lash-L closed 1 year ago

Lash-L commented 1 year ago

My python implementation of the api failed, and after some testing, it seems that usage no longer takes AccountNumber as a param. I'd double check me, but removing that fixed some issues.

apearson commented 1 year ago

Unfortunately, the changes are more than just a url change.

I'm working on a fix but it'll take a little bit.

Thank you for bring this up

Lash-L commented 1 year ago

Interesting - what other issues are you running in to? My python version has been working surprisingly well the past few days for myself (GPC), but a user with APC has been having some issues, curious if they line up.

apearson commented 1 year ago

Really the two largest issues are:

1) The URL requires the company as a query param, so I had to thread the company into the method 2) The return data structure is completely different and requires me to rewrite most of the getMonthlyData code

I am also on APC so seems like it might line up. I can send you the data structure if you want to look it over for your python lib

Lash-L commented 1 year ago
  1. Yeah - their data was all kinds of crazy for my get monthly data.

But also their hourly data is null. Do you have something similar on your side? But - I absolutely wont say no to any data structures/ changes you figure out

apearson commented 1 year ago

Rewrote getMonthlyData and published 3.0.0