search

apecloud / myduckserver

MySQL & Postgres Analytics, Reimagined
182 stars 8 forks source link

fix: support log file based positioning replication (to #155) #156

Closed VWagen1989 closed 6 days ago

VWagen1989 commented 1 week ago

This PR address the issue #155. It mainly add the supporting of file log based replication for MyDuck Server.

fanyang01 commented 6 days ago

I noticed you have injected the gtid_mode related code into the test code. IMO this is unnecessary and makes the test code harder to maintain (as it becomes significantly out-of-sync with Dolt's test). Since the tests are executed by starting a primary MySQL container and a MyDuck executable, you can just add a global environment variable for testing and according to which you can start the primary MySQL/MariaDB container in different mode.

VWagen1989 commented 6 days ago

I noticed you have injected the gtid_mode related code into the test code. IMO this is unnecessary and makes the test code harder to maintain (as it becomes significantly out-of-sync with Dolt's test). Since the tests are executed by starting a primary MySQL container and a MyDuck executable, you can just add a global environment variable for testing and according to which you can start the primary MySQL/MariaDB container in different mode.

Sounds reasonable