apeisa / UserGroups

Adds users groups and page based permission to ProcessWire
GNU General Public License v2.0
11 stars 4 forks source link

Rewrote parts of save() to handle empty group definitions properly and make sure all edit groups have view access too #2

Closed niklaka closed 10 years ago

niklaka commented 10 years ago

Access inheritance wasn't rebuilt when manage_access was checked but no groups were selected, this is now fixed. Another commit adds a line making sure all edit groups have view access as well. There would have been other ways around this, but this was the most straightforward at this point. Another option would have been to change viewable() to check for edit groups as well.

I was supposed to add more fixes/additions to this same pr but it turns out I need to get around that circular reference problem first. Stay tuned :).

niklaka commented 10 years ago

Not quite there with GitHub/git... I've got that circular ref workaround but it has all of this too - and I'm not sure how to deal with it as these haven't been merged yet. So let's close this one and I'll make you another pull req soon.