search

apeisa / UserGroups

Adds users groups and page based permission to ProcessWire
GNU General Public License v2.0
11 stars 4 forks source link

Fix issue with getAccessPage() not working properly for Repeaters #41

Open teppokoivula opened 9 years ago

teppokoivula commented 9 years ago

This PR adds Repeater support to getAccessPage() and fixes an issue where secure files weren't viewable at all for some users.

I'm not merging this to master yet, as I'd like to get a second opinion on this first. I'm not really familiar with UserGroupsHooks and it's features, so it's possible that I'm missing something obvious here, or perhaps there's a cleaner way to do the same thing?

/cc @apeisa @niklaka

PS. While pushing this branch to GitHub, I managed to bring in couple of local commits that were never intended here. Minor stuff, file permissions and such. I've already reverted the changes, but.. sorry for making unnecessary mess in the commit history :)

teppokoivula commented 9 years ago

@apeisa @niklaka Unless you can see any reason not to, I'm going to merge this branch to master soon. This fix has been in place on couple of sites since March, and so far I haven't witnessed any harmful side-effects.