search

apel / ssm

Secure STOMP Messenger.
apel.github.io
Apache License 2.0
11 stars 24 forks source link

Update files for docker build on rocky 9 #327

Closed Will-Cross1 closed 6 months ago

Will-Cross1 commented 6 months ago

removed version constraints on dependencies as we don't need them for python 3 added separate requirements file for docker to keep python 3 dependencies separate

Resolves #315 Resolves #286

Sae126V commented 6 months ago

Just a general question. Have you verified the pip and system requirements mentioned in the Dockerfile works as expected in the image mentioned?

I see that in the Dockerfile, Say, it says

centos:7 RUN yum -y install python-pip

In Rocky 9. I think it should be RUN yum -y install python3-pip

Please correct me If I am wrong.

tofu-rocketry commented 6 months ago

Just a general question. Have you verified the pip and system requirements mentioned in the Dockerfile works as expected in the image mentioned?

I see that in the Dockerfile, Say, it says

centos:7 RUN yum -y install python-pip

In Rocky 9. I think it should be RUN yum -y install python3-pip

Please correct me If I am wrong.

That is a good point. I think the Docker build might still work as it already has pip Python 3, but I agree that we should standardise the installs on the installed Python version.