hbbingham
commented
8 years ago Hej Bo,
Thanks for those additions to the code and I'm sorry to be so slow to respond. You introduced a couple of bugs (the JONSWAPspectrum routine is also used by 3D waves) which I corrected and I also extended the local smoothing filter breaking model to 3D.
Cheers,
Harry
On Wed, 2015-12-23 at 06:36 -0800, Bo Terp Paulsen wrote:
Hej Allan,
Jeg har lavet foelgende updates til OceanWave3D:
src: ) Additional irregular wave type (ispec=3) is added. Users can now specify gamma (peak enhancement factor) for the spectrum. Old input files (ispec={0,1,2}) are still supported ) I cleaned up the last part of the "ReadInputFilesParameters.f90" and replaced most "GO TO" statements with IF sentences, since they are easier to read and less error prone.
GUI: ) Important bug-fix for generation of random irregular (JONSWAP) waves: seed values are changed from a positive to a negative number as required by "ran_1b". ) Small bug-fixes for 3D domains *) Gamma value for JONSWAP waves added to interface and to IO functions
/Bo
You can view, comment on, or merge this pull request online at: https://github.com/apengsigkarup/OceanWave3D-Fortran90/pull/3
Commit Summary * small bug fixes for the GUI. Only for 3D * GUI: * small bug fix * Silly debug statement was still in code File Changes * M GUI/MainWindow/runAndWrite.cpp (45) * M GUI/MainWindow/waveGeneration.cpp (8) * M GUI/customgrid.cpp (5) * M GUI/mainwindow.h (1) * M GUI/mainwindow.ui (42) * M common.mk (4) * M src/IO/ReadInputFileParameters.f90 (91) * M src/main/OceanWave3DT0Setup.f90 (8) * M src/utilities/JONSWAP_spectrum.f90 (3) * M src/utilities/build_coeff.f90 (6) * M src/utilities/random_wave_coefficients.f90 (9) * M src/variabledefs/datatypes.f90 (2) Patch Links: * https://github.com/apengsigkarup/OceanWave3D-Fortran90/pull/3.patch * https://github.com/apengsigkarup/OceanWave3D-Fortran90/pull/3.diff
— Reply to this email directly or view it on GitHub.
Hej Allan,
Jeg har lavet foelgende updates til OceanWave3D:
src: ) Additional irregular wave type (ispec=3) is added. Users can now specify gamma (peak enhancement factor) for the spectrum. Old input files (ispec={0,1,2}) are still supported ) I cleaned up the last part of the "ReadInputFilesParameters.f90" and replaced most "GO TO" statements with IF sentences, since they are easier to read and less error prone.
GUI: ) Important bug-fix for generation of random irregular (JONSWAP) waves: seed values are changed from a positive to a negative number as required by "ran_1b". ) Small bug-fixes for 3D domains *) Gamma value for JONSWAP waves added to interface and to IO functions
/Bo