search

apengsigkarup / OceanWave3D-Fortran90

OceanWave3D - a very efficient coastal engineering research tool used worldwide for simulation of nonlinear and dispersive free surface waves in varying bathymetries from very deep to shallow water. Learn more about the model:
http://www2.compute.dtu.dk/~apek/OceanWave3D/
Other
68 stars 37 forks source link

Is it a bug in file "PreprocessPDampingZones.f90"? #5

Open trimtrim opened 5 years ago

trimtrim commented 5 years ago

At line 45 of PreprocessPDampingZones.f90, the nyd is computed by i3-i4+1, which may be a negative value. nyd=i3-i4+1; PDampZones(i)%ny=nyd; nd=nxd*nyd

Does it need to change nyd = i4-i3+1??

hbbingham commented 5 years ago

Yes, that is indeed a bug and it should be i4-i3+1. Thanks for pointing that out.

Best regards, Harry

From: trimtrim notifications@github.com Sent: 9. september 2019 03:15 To: apengsigkarup/OceanWave3D-Fortran90 OceanWave3D-Fortran90@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [apengsigkarup/OceanWave3D-Fortran90] Is it a bug in file "PreprocessPDampingZones.f90"? (#5)

At line 45 of PreprocessPDampingZones.f90, the nyd is computed by i3-i4+1, which may be a negative value. nyd=i3-i4+1; PDampZones(i)%ny=nyd; nd=nxd*nyd

Does it need to change nyd = i4-i3+1??

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/apengsigkarup/OceanWave3D-Fortran90/issues/5?email_source=notifications&email_token=ADL6A3VKO5TGGTIJGSQK4FDQIWPRFA5CNFSM4IUVSICKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKBRQKA, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADL6A3QVJVX7YRL32DMGO23QIWPRFANCNFSM4IUVSICA.

trimtrim commented 5 years ago

Thanks for the confirmation. Best regards!