search

apereo / dotnet-cas-client

Apereo .NET CAS Client
Apache License 2.0
234 stars 172 forks source link

Cleanup Duplicate/Unused Assembly References #77

Closed TheHokieCoder closed 6 years ago

TheHokieCoder commented 6 years ago

Noticed today that the DotNetCasClient project is referencing a lot of .NET assemblies that are never used, more than likely from the bloated templates that Visual Studio provides out-of-the-box. To keep things lean and mean, I'd like to remove the unused assemblies (by no means difficult to add back should they need to be referenced in the future). Also, there are two groupings of references to separate .NET20/35 and .NET40/45, but they reference many of the same assemblies. I plan to merge the shared assemblies together in one item grouping in the .csproj file, leaving only the differing assemblies in the conditional groupings. The end result should be leaner resource usage with no functional changes.

Anyone against these two changes?

phantomtypist commented 6 years ago

Unused references: that's fine as long as the build script runs without error.

Duplicate references: I guess that's fine for now, but I might have to break them back out when I add the .NET Core target. I'm not sure if the namespaces are the same or not.

TheHokieCoder commented 6 years ago

I might have to break them back out when I add the .NET Core target.

Ahh, for some reason I was under the impression that .NET Standard/Core was going to be a wholly new project due to the vast changes in the security model.

phantomtypist commented 5 years ago

Included in release 1.2.0