search

apereo / phpCAS

Apereo PHP CAS Client
https://apereo.github.io/phpCAS/
Apache License 2.0
795 stars 396 forks source link

Warning: Unexpected character input #314

Closed jamac closed 5 years ago

jamac commented 5 years ago

https://github.com/apereo/phpCAS/blob/ff165bf94c62b4cb76c5eebd3ea3d157c24e527c/source/CAS.php#L1877

Warning: Unexpected character in input: '\' (ASCII=92) state=1 in /web/staging/CAS/CAS-1.3.8/CAS.php on line 1877

I must be the only poor schmuck required to run this on PHP 5.2. Is \CAS_Client required? or would CAS_Client suffice?

I know it's just a warning, but that warning is interfering with the redirect to our login page.

If I remove the \ everything appears fine, but I honestly can't say I know what all the ramifications are.

If I grep -FRi "(\\CAS" the repo this is the only instance I can find (excluding ./docs)

jfritschi commented 5 years ago

The slash was introduced with php namespacing in php 5.3 https://www.php.net/manual/de/language.namespaces.importing.php

Removing it should make no difference for you.

PHP: Namespaces verwenden: Aliase/Importieren - Manual
phy25 commented 5 years ago

Closing since: https://github.com/apereo/phpCAS/blob/ff165bf94c62b4cb76c5eebd3ea3d157c24e527c/composer.json#L13

jamac commented 5 years ago

Trying reply by email.

Super. Thanks for the help.

From: Joachim Fritschi notifications@github.com Sent: Sunday, September 1, 2019 4:48:56 AM To: apereo/phpCAS phpCAS@noreply.github.com Cc: Macdonald, Jay jay.macdonald@uleth.ca; Author author@noreply.github.com Subject: Re: [apereo/phpCAS] Warning: Unexpected character input (#314)

The slash was introduced with php namespacing in php 5.3 https://www.php.net/manual/de/language.namespaces.importing.php

Removing it should make no difference for you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/apereo/phpCAS/issues/314?email_source=notifications&email_token=AAOJSTZRNGIZF3G2Q52CKFTQHOMZRA5CNFSM4IRO42HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5T7SWY#issuecomment-526907739, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAOJSTZMPXO7GDK6BYEL74LQHOMZRANCNFSM4IRO42HA.