search

apereo / phpCAS

Apereo PHP CAS Client
https://apereo.github.io/phpCAS/
Apache License 2.0
795 stars 396 forks source link

deprecation warning in php 8.1.2 #416

Closed carl-welch closed 2 years ago

carl-welch commented 2 years ago

PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /path/to/vendor/apereo/phpcas/source/CAS/Client.php on line 1041

Maybe change null to the empty string on line 1040?

$ticket = (isset($_GET['ticket']) ? $_GET['ticket'] : '');

jfritschi commented 2 years ago

This issue may have been solved with a recent pull

https://github.com/apereo/phpCAS/pull/415

Can you please check against the current master branch?

carl-welch commented 2 years ago

Yes, I was looking at the v1.4.0 release and didn't think to look at master. Sorry about that. Looks great, tnx.