get-pup: Use a fork of pup on recent macOS

aperezdc / ngx-fancyindex

Fancy indexes module for the Nginx web server

Other

857 stars 127 forks source link

get-pup: Use a fork of pup on recent macOS #145

Closed ryandesign closed 2 years ago

ryandesign commented 2 years ago

Use a fork of pup on macOS 10.13 and higher because the binary provided by the original project crashes immediately on those OS versions.

See https://github.com/ericchiang/pup/issues/85

ryandesign commented 2 years ago

Note: this does require the user to install xz first (using MacPorts, Homebrew, etc.). xz is not included in macOS.

ryandesign commented 2 years ago

I have another PR ready to submit to add macOS test runners but of course they won't be very useful if this PR isn't merged first.

aperezdc commented 2 years ago

@ryandesign Thanks again for figuring out how to get things working on MacOS, which is something hard for me as I do not have easy access to Apple hardware around. It's much appreciated 🤗