search

apernet / OpenGFW

OpenGFW is a flexible, easy-to-use, open source implementation of GFW (Great Firewall of China) on Linux
https://gfw.dev/
Mozilla Public License 2.0
9.59k stars 722 forks source link

fix: cannot trap sigkill -9 #99

Closed rfyiamcool closed 6 months ago

rfyiamcool commented 6 months ago

summary

App cannot sigkill -9. we can trap sigterm -15, kill command send sigterm -15 signal by default.

https://en.wikipedia.org/wiki/Signal_(IPC)#SIGKILL

image

macie commented 6 months ago

According to docs, it is safe to remove os.Kill.

I've fixed this error as a part of #98 (in 3022bde).

tobyxdd commented 6 months ago

Many thanks for bringing this up, but it's been fixed as part of #98 so I'm closing this

rfyiamcool commented 6 months ago

Many thanks for bringing this up, but it's been fixed as part of #98 so I'm closing this

ok 😁