Continuum fixes (please test before merging)

[adebahr]

• write out the right image file for last continuum iteration
• add the right statistics to the parameter file for images

[pep8speaks]

Hello @adebahr! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file apercal/modules/continuum.py:

Line 128:28: E711 comparison to None should be 'if cond is not None:' Line 177:59: E226 missing whitespace around arithmetic operator Line 266:106: E226 missing whitespace around arithmetic operator Line 267:62: E226 missing whitespace around arithmetic operator Line 280:85: E226 missing whitespace around arithmetic operator Line 358:82: E225 missing whitespace around operator Line 402:25: E722 do not use bare 'except' Line 565:50: E111 indentation is not a multiple of four Line 749:201: E501 line too long (268 > 200 characters)

• In the file apercal/modules/mosaic.py:

Line 50:5: E303 too many blank lines (2) Line 57:5: E303 too many blank lines (2) Line 66:91: E261 at least two spaces before inline comment Line 67:131: E261 at least two spaces before inline comment Line 68:121: E261 at least two spaces before inline comment Line 69:125: E261 at least two spaces before inline comment Line 70:145: E261 at least two spaces before inline comment Line 71:145: E261 at least two spaces before inline comment Line 74:9: E303 too many blank lines (2) Line 86:201: E501 line too long (207 > 200 characters) Line 120:25: E722 do not use bare 'except' Line 156:5: E303 too many blank lines (2) Line 182:5: E303 too many blank lines (2)

• In the file apercal/modules/polarisation.py:

Line 62:5: E303 too many blank lines (2) Line 115:69: E226 missing whitespace around arithmetic operator Line 203:69: E226 missing whitespace around arithmetic operator Line 309:5: E303 too many blank lines (2) Line 313:5: E303 too many blank lines (2) Line 336:5: E303 too many blank lines (2) Line 356:94: W292 no newline at end of file

• In the file apercal/modules/scal.py:

Line 284:57: E231 missing whitespace after ',' Line 628:120: E231 missing whitespace after ','

• In the file apercal/pipeline/start_pipeline.py:

Line 8:1: E265 block comment should start with '# '

• In the file apercal/subs/combim.py:

Line 12:35: E231 missing whitespace after ',' Line 12:38: E231 missing whitespace after ','

• In the file apercal/subs/imstats.py:

Line 44:45: E231 missing whitespace after ',' Line 44:47: E231 missing whitespace after ',' Line 44:49: E231 missing whitespace after ',' Line 45:45: E231 missing whitespace after ',' Line 45:47: E231 missing whitespace after ',' Line 45:49: E231 missing whitespace after ',' Line 46:45: E231 missing whitespace after ',' Line 46:47: E231 missing whitespace after ',' Line 46:49: E231 missing whitespace after ','

• In the file apercal/subs/masking.py:

Line 324:49: E251 unexpected spaces around keyword / parameter equals Line 324:51: E251 unexpected spaces around keyword / parameter equals Line 325:1: W391 blank line at end of file

Comment last updated at 2019-06-11 13:29:09 UTC

[eakadams]

The changes for outputting the correct mfs image have negatively impacted the output of the chunk images. The pipeline produces an incorrect name for the chunk image and fails:

04/16/2019 03:37:19 PM - apercal.modules.continuum - INFO : Beam 23: Chunk 00: Dynamic range is 75.805 for cycle 1
04/16/2019 03:37:19 PM - apercal.modules.continuum - INFO : Beam 23: Chunk 00: Chunk successfully imaged!
04/16/2019 03:37:19 PM - masher - DEBUG : fits in=image_C00_[1] op=xyout out=image_C00_[1].fits 
04/16/2019 03:37:19 PM - basher - DEBUG : fits in=image_C00_[1] op=xyout out=image_C00_[1].fits 
04/16/2019 03:37:19 PM - basher - DEBUG : Command = fits in=image_C00_[1] op=xyout out=image_C00_[1].fits 
04/16/2019 03:37:19 PM - basher - DEBUG : 

fits: Revision 1.33, 2018/12/04 04:02:11 UTC

04/16/2019 03:37:19 PM - basher - DEBUG : ### Warning:  Error opening image_C00_[1], in XYOPEN
### Fatal Error:  No such file or directory

[rs1701]

Testing was done with start_pipeline and did not crash