apertif / apercal

GNU General Public License v3.0
3 stars 9 forks source link

Apercal aaf #260

Closed Anqi-Li-rug closed 4 years ago

Anqi-Li-rug commented 5 years ago

Modifications for after-AAF data.

rs1701 commented 5 years ago

If I read the changes right, the branch would delete the current settings in preflag.edges() and create_bandpass() and put AAF-required settings in their place. I think that we should not replace the settings in preflag.edges() and create_bandpass() at this stage. Since the AAF-module will be a new addition, it is better to keep the pipeline backwards compatible and keep both settings. I think that we can achieve this with an additional config setting. I will take care of this when I implement the AAF module. => For the moment, please do not merge this branch.

rs1701 commented 4 years ago

Changes have been made but AAF itself still requires further testing