Redir of stderr/-out not enough, use logging.basicConfig(filename=…)

apertium / apertium-apy

📦 Apertium HTTP Server in Python

https://wiki.apertium.org/wiki/Apertium-apy

GNU General Public License v3.0

32 stars 42 forks source link

Redir of stderr/-out not enough, use logging.basicConfig(filename=…) #116

Closed unhammer closed 6 years ago

unhammer commented 6 years ago

Also, the basicConfig stuff needs to happen before any loggers are created, otherwise it has no effect (or you have to pass in the created loggers to basicConfig, which sounds like a drag).

Fixes #112 - apertium-apy doesn't honor -P / --log-path

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 987

5 of 19 (26.32%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 45.089%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
apertium_apy/apy.py	5	19	26.32%
<!--	Total:	5	19	26.32%	-->

Totals
Change from base Build 970:	-0.1%
Covered Lines:	1057
Relevant Lines:	2111

apertium / apertium-apy

Redir of stderr/-out not enough, use logging.basicConfig(filename=…) #116

Pull Request Test Coverage Report for Build 987

💛 - Coveralls