apertium / apertium-apy

📦 Apertium HTTP Server in Python
https://wiki.apertium.org/wiki/Apertium-apy
GNU General Public License v3.0
32 stars 42 forks source link

Switch to pipenv #118

Closed ghost closed 5 years ago

ghost commented 5 years ago

Still some problems with the lint

ghost commented 5 years ago

OK, resolving style checker errors might take a while... (It's the middle of the night in Germany, so I'm going to bed now). I'll do the linter issues tomorrow. Afterwards the build should not fail

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1062


Totals Coverage Status
Change from base Build 1048: 0.0%
Covered Lines: 1057
Relevant Lines: 2111

💛 - Coveralls
ghost commented 5 years ago

OK, seems to be some kind of version support error, let me just try something...

ghost commented 5 years ago

mypy in requirements.txt "python_version >= '3.5' # we DO NOT want the typing backport" anyone got an idea how to fix this?

sushain97 commented 5 years ago

@milanandreew pipenv also supports markers like this one. e.g. see this marker in streamparser: https://github.com/apertium/streamparser/blob/master/Pipfile#L15

ghost commented 5 years ago

$ NONPAIRS=/tmp/languages python -m unittest tests/test*.py Traceback (most recent call last): File "/opt/python/3.4.6/lib/python3.4/runpy.py", line 170, in _run_module_as_main "__main__", mod_spec) File "/opt/python/3.4.6/lib/python3.4/runpy.py", line 85, in _run_code exec(code, run_globals) File "/opt/python/3.4.6/lib/python3.4/unittest/__main__.py", line 18, in <module> main(module=None) File "/opt/python/3.4.6/lib/python3.4/unittest/main.py", line 92, in __init__ self.parseArgs(argv) File "/opt/python/3.4.6/lib/python3.4/unittest/main.py", line 139, in parseArgs self.createTests() File "/opt/python/3.4.6/lib/python3.4/unittest/main.py", line 146, in createTests self.module) File "/opt/python/3.4.6/lib/python3.4/unittest/loader.py", line 157, in loadTestsFromNames suites = [self.loadTestsFromName(name, module) for name in names] File "/opt/python/3.4.6/lib/python3.4/unittest/loader.py", line 157, in <listcomp> suites = [self.loadTestsFromName(name, module) for name in names] File "/opt/python/3.4.6/lib/python3.4/unittest/loader.py", line 125, in loadTestsFromName parent, obj = obj, getattr(obj, part) AttributeError: 'module' object has no attribute 'test' I have no idea what has caused this error.

ghost commented 5 years ago

Until tomorrow.

sushain97 commented 5 years ago

Please refrain from opening and closing this PR.

sushain97 commented 5 years ago

You're likely running into this error: https://stackoverflow.com/questions/25575073/attributeerror-module-object-has-no-attribute-tests. I suggest SSHing into the Travis CI box and seeing whether you can successfully start APy. You can also install Python 3.4 locally (might not be able to duplicate the issue).

ghost commented 5 years ago

Sorry, I always click the "Close and Comment" button by accident.

ghost commented 5 years ago

it says ImportError: cannot import name 'PIPE_BUF' from 'select'

ghost commented 5 years ago

VIM (No, i'm not referring to improved vi, VIM stands for "very important milestone"). TODO: check which dependency versions need to be pinned.

ghost commented 5 years ago

So the 3.5 build can't cope with an outdated pipfile lock. And it seems like the 3.4 problem has something to do with tornado.

ghost commented 5 years ago

Here comes the tricky bit

ghost commented 5 years ago

enhancement complete