apertium / apertium-apy

📦 Apertium HTTP Server in Python
https://wiki.apertium.org/wiki/Apertium-apy
GNU General Public License v3.0
32 stars 42 forks source link

Upgrading flake8 version whilst fixing style issues it's complaining about #123

Closed ghost closed 5 years ago

ghost commented 5 years ago

Question: Is it OK if I just ignore W504?

ghost commented 5 years ago

I'll just ignore W504.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1085


Totals Coverage Status
Change from base Build 1072: 0.02%
Covered Lines: 1058
Relevant Lines: 2112

💛 - Coveralls
sushain97 commented 5 years ago

Not unless there's a good reason to.

ghost commented 5 years ago

Well, it is just a linebreak error, but it still shows up after i fixed it, so i doubt it.

sushain97 commented 5 years ago

Have you tried using flake8 locally?

ghost commented 5 years ago

Yep.

sushain97 commented 5 years ago

Ahh, I think you have to ignore one of them since they're contradictory. So go ahead and ignore the one that allows for the smallest diff.

ghost commented 5 years ago

OK.

sushain97 commented 5 years ago

Thanks for taking care of this!