TSV source for langNames #115

apertium / apertium-apy

📦 Apertium HTTP Server in Python

https://wiki.apertium.org/wiki/Apertium-apy

GNU General Public License v3.0

32 stars 42 forks source link

TSV source for langNames #115 #128

Closed ayushjainrksh closed 5 years ago

ayushjainrksh commented 5 years ago

I have started working on the issue 115 and created tsv files for sql queries. I haven't deleted the original sql files for now. I have also written python script that needs to be build at make so that tsv files may be converted to sql and inserted to db.

sushain97 commented 5 years ago

Please remove all the extra commits. You should be working on a branch without them and merging into master here.

ayushjainrksh commented 5 years ago

Okay I will remove all the extra commits. Please check my PRs.

sushain97 commented 5 years ago

I can't review this PR until the extra commits are reviewed. The changeset is a mess.

ayushjainrksh commented 5 years ago

I have removed most of the extra commits.

sushain97 commented 5 years ago

I'd still like the other commits to be removed. Please use a branch so development is simple. You can cherry-pick the relevant commits into it.

Also, I think the TSVs don't need the number at the start. They can be autogenerated?

ayushjainrksh commented 5 years ago

I have removed the ids at the beginning of the tsv files and they are auto-generating now. Should I use a single branch for all the PRs I send? If so how do I manage the different issues?

coveralls commented 5 years ago

Coverage increased (+0.04%) to 45.158% when pulling f480c6e833650edb2bed1cb26b9b616a59538214 on ayushjainrksh:TSV into eb986aa7c7f93bdddbff554f187d8a1bbf7187a7 on apertium:master.

coveralls commented 5 years ago

Coverage increased (+0.09%) to 45.211% when pulling 87d5d6f111676ff65fcf5b07c2b8c579ed134f5c on ayushjainrksh:TSV into eb986aa7c7f93bdddbff554f187d8a1bbf7187a7 on apertium:master.

sushain97 commented 5 years ago

No, each PR should come from a different branch on your fork.