search

apertium / apertium-apy

📦 Apertium HTTP Server in Python
https://wiki.apertium.org/wiki/Apertium-apy
GNU General Public License v3.0
32 stars 42 forks source link

Combine/de-duplicate turkic.tsv #132

Open jonorthwash opened 5 years ago

jonorthwash commented 5 years ago

Some language name overrides are not being honored. E.g., beta.apertium.org and turkic.apertium.org both show "Tuvinian" in English for tyv despite the presence of "Tuvan" as an override.

Also, I don't understand why some Turkic-language overrides are in turkic.sql and some are in manual.sql. Is this intentional?

sushain97 commented 5 years ago

Also, I don't understand why some Turkic-language overrides are in turkic.sql and some are in manual.sql. Is this intentional?

Probably an artifact of pre-split.

Your first question looks like a bug though. Will investigate.

sushain97 commented 5 years ago

I think turkic.sql is a file you created with a subset of the other language names just for turkic.apertium.org? I can't really recall exactly what the intent was.

Regardless, it has a bunch of duplication with the other files and is not actually used in the language names DB compilation:

cat language_names/scraped.sql language_names/scraped-sil.sql language_names/manual.sql language_names/variants.sql | sqlite3 langNames.db
jonorthwash commented 5 years ago

I think originally turkic.sql was the only overrides. Perhaps we should move the non-duplicated stuff to the main overrides file and get rid of turkic.sql?

sushain97 commented 5 years ago

Good plan. After https://github.com/apertium/apertium-apy/pull/131 gets merged, it can be taken care of.

jonorthwash commented 5 years ago

Oh, I thought we'd talked about this before. Indeed we have.