search

apertium / apertium-apy

📦 Apertium HTTP Server in Python
https://wiki.apertium.org/wiki/Apertium-apy
GNU General Public License v3.0
32 stars 42 forks source link

Issue 115 - TSV scraped files #134

Closed sushain97 closed 5 years ago

sushain97 commented 5 years ago

Branching off of https://github.com/apertium/apertium-apy/pull/131

sushain97 commented 5 years ago

@ayushjainrksh please take a look at my last couple of commits. They clean up your approach to sorting which was a bit roundabout. I also clean up the code in general and the README. The new approach to getting the apertium languages is also much more effective. Will take a look in a bit and let you know if there's anything else to handle.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.5%) to 45.676% when pulling f7fb04ceb5b084da093ddec210e103841b9e1478 on ayushjainrksh-issue115 into 7fc77432ba1953083a36f81b1945d3e259c840f1 on master.

ayushjainrksh commented 5 years ago

I have checked the changes, looks great :)

ayushjainrksh commented 5 years ago

I like the use of lambda function for sorting. Its simple and convenient.