search

apertium / apertium-apy

📦 Apertium HTTP Server in Python
https://wiki.apertium.org/wiki/Apertium-apy
GNU General Public License v3.0
32 stars 42 forks source link

Support Mainline Distro Dependencies #99

Closed TinoDidriksen closed 6 years ago

TinoDidriksen commented 6 years ago

APy should support a much wider range of dependencies, most important being the ones you can get via apt-get on the various supported distros. PyPi isn't enough: https://github.com/apertium/apertium-apy/pull/91#issuecomment-376473818

E.g., for python3-tornado this means a range of versions in Debian and Ubuntu that comes out to: 3.1 (trusty) 3.2 (jessie) 4.2 (xenial) 4.4 (stretch) 4.5 (artful+bionic) 5.0 (buster+sid)

We can cut away old versions, such as dropping support for 3.x (trusty+jessie), but future versions will keep happening and must work.

sushain97 commented 6 years ago

I don't think it's worth supporting 3.1 and 3.2. 4.2 may be supported in rc2 but I'll need to verify that this evening. If it is, I'll drop the requirements in setup.py and requirements.txt so that CI runs against 4.2. Supporting 5.0 is a separate concern I might have time to look into...

sushain97 commented 6 years ago

Continuing discussion from #91: given that APy completely breaks on Tornado 5.0, the ceiling requirement is here to stay until the issue is fixed in APy. At least this way, PyPi consumers won't get a broken package.

sushain97 commented 6 years ago

Didn't require any changes to fix for 4.2 (xenial). Released on PyPi and tagged as v0.11.0.rc3. CI will also run against 4.2.1 now.

sushain97 commented 6 years ago

https://github.com/apertium/apertium-apy/pull/102 may fix 5.0. Waiting for go-ahead from @unhammer.

TinoDidriksen commented 6 years ago

On latest Debian Sid, with python3-tornado (5.0.0-2) installed, I get:

apertium_apy.handlers (unittest.loader._FailedTest) ... ERROR
...
  File ".../apertium_apy/handlers/base.py", line 15, in <module>
    class BaseHandler(tornado.web.RequestHandler):
AttributeError: module 'tornado' has no attribute 'web'
sushain97 commented 6 years ago

Unfortunately, I'm unable to repro the problem.

sushain97 commented 6 years ago

https://github.com/apertium/apertium-apy/issues/84 is now the real problem. Conversation is on IRC regarding it.