search

apertium / apertium-html-tools

Web application providing a fully localised interface for text/website/document translation, analysis and generation powered by Apertium.
http://wiki.apertium.org/wiki/Apertium-html-tools
GNU General Public License v3.0
39 stars 90 forks source link

Fail more gracefully when APy is down #207

Closed sushain97 closed 3 years ago

sushain97 commented 7 years ago

currently the interface looks incorrectly aligned...

see #206 for screenshots

Androbin commented 6 years ago

@sushain97 Do you have suggestions for an appropriate error message and how to display it?

sushain97 commented 6 years ago

Ideally, none. Everything should just respond with no translation available (and without junky alignment).

Androbin commented 6 years ago

What do we know yet about the cause of the layout issue? I'd suspect that some part of the script gets stuck during a DOM modification.

sushain97 commented 6 years ago

Nothing as far as I know.

On Dec 27, 2017 5:40 AM, "Robin Richtsfeld" notifications@github.com wrote:

What do we know yet about the cause of the layout issue? I'd suspect that some part of the script gets stuck during a DOM modification.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/goavki/apertium-html-tools/issues/207#issuecomment-354101484, or mute the thread https://github.com/notifications/unsubscribe-auth/AEBEfvuviSSddzsfUlROQB4PkA101N9Sks5tEiyfgaJpZM4PA6e3 .

Androbin commented 6 years ago

Which parts of the initial DOM construction could be blocked when APy is down? Which parts of a fresh page are generated by code that's interlaced with networking code?

sushain97 commented 6 years ago

I don't carry all this information in my head. Figuring it out would be part of fixing the issue.

On Dec 27, 2017 9:29 AM, "Robin Richtsfeld" notifications@github.com wrote:

Which parts of the initial DOM construction could be blocked when APy is down? Which parts of a fresh page are generated by code that's interlaced with networking code?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/goavki/apertium-html-tools/issues/207#issuecomment-354129745, or mute the thread https://github.com/notifications/unsubscribe-auth/AEBEfiPJsNNEqf_mKxC54k8Lvps2u2toks5tEmJKgaJpZM4PA6e3 .

Androbin commented 6 years ago

I don't carry all this information in my head. Figuring it out would be part of fixing the issue.

No deal, it'd just be wasted effort if you had some idea.

sushain97 commented 3 years ago

This should no longer be an issue on master. The UI renders completely independently of any network requests.