Closed sushain97 closed 3 years ago
On mobile layouts, the localisation dropdown appears all the way down at the bottom. It would be good to to have it on the top.
Have you tested RTL localisations on mobile platforms. There are a few things that don't seem to line up nicely or flip sides. I'm not sure what was intentional and what just wasn't undertaken in your efforts.
On mobile layouts, the localisation dropdown appears all the way down at the bottom. It would be good to to have it on the top.
That's the same as the current behavior? If we want to change that, I'd rather do it as a separate issue :)
Have you tested RTL localisations on mobile platforms. There are a few things that don't seem to line up nicely or flip sides. I'm not sure what was intentional and what just wasn't undertaken in your efforts.
I might have missed some minor UI things -- don't think I tested RTL + mobile. I'll take a closer look.
@jonorthwash landed a bunch of fixes https://github.com/sushain97/apertium-html-tools-v2/commit/1a9b5a4d7e154952c87dc6e0e19059a740e83b8f.
I don't know if the issues in this screenshot with placement of language selection stuff is a new thing—I remember it being a thing in the past. But I thought I'd bring it up just in case it's new / a regression.
The menu for selecting the localisation also doesn't align language names based on their script direction, which the current html-tools does.
The menu for selecting the localisation also doesn't align language names based on their script direction, which the current html-tools does.
Ohhh, this is probably a regression, should be an easy fix. Will take a look later today.
I don't know if the issues in this screenshot with placement of language selection stuff is a new thing—I remember it being a thing in the past. But I thought I'd bring it up just in case it's new / a
What's wrong here? The wrapping on to two lines? Yeah, think that's the same.
The menu for selecting the localisation also doesn't align language names based on their script direction, which the current html-tools does.
I was not actually able to reproduce this issue in my browser but I've pushed what I think is a fix for it regardless.
Correction: reproduced and verified to be fixed using Firefox.
@unhammer @xavivars I noticed y'all didn't have any 👍s here yet :) Any thoughts? Planning to merge later this week.
I haven't found anything to complain about =P It looks great :grinning:
Same thing, haven't seen anything, except CircleCI config missing (I guess Github Actions are the replacement).
Otherwise, looks good to me.
This PR is a complete rewrite of
apertium-html-tools
in React + TypeScript with an ESBuild + Node build toolchain. Fixes https://github.com/apertium/apertium-html-tools/issues/351. Pretty sure I also fixed https://github.com/apertium/apertium-html-tools/issues/384, https://github.com/apertium/apertium-html-tools/issues/373, https://github.com/apertium/apertium-html-tools/issues/357, https://github.com/apertium/apertium-html-tools/issues/266 and more along the way.This is pulled from https://github.com/sushain97/apertium-html-tools-v2 where you can easily browse the source. Before I merge this PR, I will pull in any changes from that repo.
For your ease of testing, I've hosted a version here: https://azurite.skc.name/apertium-html-tools-v2/dist/.
Advantages
data-src
unnecessary and generally improving perf)Disadvantages
old.apertium.org
.Rollout plan
master
will be moved to av4
branchmaster
and tagged asv5.0.0
. It will be deployed tobeta.apertium.org
beta.apertium.org
,apertium.org
will also be portedCurrently missing/removed features
apertium.org
norbeta.apertium.org
use it)master
If you are using/need the above features, let me know. I can probably add them back with relative ease.
cc @xavivars @unhammer @jonorthwash @TinoDidriksen