Target ES2019 (fixes #417)

apertium / apertium-html-tools

Web application providing a fully localised interface for text/website/document translation, analysis and generation powered by Apertium.

http://wiki.apertium.org/wiki/Apertium-html-tools

GNU General Public License v3.0

39 stars 90 forks source link

Target ES2019 (fixes #417) #418

Closed TinoDidriksen closed 3 years ago

TinoDidriksen commented 3 years ago

As per https://esbuild.github.io/api/#target default is esnext which is way too new. Target should be $YEAR - 5, currently ES2016.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1016276785

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.224%

Totals
Change from base Build 976651424:	0.0%
Covered Lines:	1353
Relevant Lines:	1368

💛 - Coveralls

sushain97 commented 3 years ago

Target should be $YEAR - 5, currently ES2016.

Are there any browsers versions from 2016 which are not EOL? Given how fast browser vendors release security patches, I'd be pretty surprised. Depending on impact to bundle size, I'd prefer starting somewhere like ES2019 instead. That should fix #417 and then we can reconsider if anyone else pops out of the woodworks.

TinoDidriksen commented 3 years ago

Sure, sounds good. Looks like distros package recent browsers even for stable old distros.