apertium / apertium-html-tools

Web application providing a fully localised interface for text/website/document translation, analysis and generation powered by Apertium.
http://wiki.apertium.org/wiki/Apertium-html-tools
GNU General Public License v3.0
39 stars 90 forks source link

Tweak style prefs layout #457

Closed sushain97 closed 1 year ago

sushain97 commented 1 year ago

Hopefully fixes https://github.com/apertium/apertium-html-tools/issues/435 (sorry for the delay on this).

image

image

It isn't the greatest but I think it's reasonable enough?

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4217804591


Totals Coverage Status
Change from base Build 4215318940: 0.003%
Covered Lines: 1376
Relevant Lines: 1391

💛 - Coveralls
unhammer commented 1 year ago

Yeah, that helps :)

The scroll bar indicator gets almost invisible when I make it mobile-sized, but maybe it's more visible on an actual phone? Also, can it be taller? (I see it has a max-height, which I can increase, is it set kind of low just in case it goes outside the viewport or whatever it's called?)

Not a big thing though, this is a big enough improvement that I'd like to get it merged asap :)

sushain97 commented 1 year ago

I see it has a max-height, which I can increase, is it set kind of low just in case it goes outside the viewport or whatever it's called?

Yeah, the idea here was just to keep it roughly inside the viewport for standard screen sizes.

The scroll bar indicator gets almost invisible when I make it mobile-sized, but maybe it's more visible on an actual phone?

I gave it a look and it seems alright! Good flag.

Not a big thing though, this is a big enough improvement that I'd like to get it merged asap :)

👍 A larger change we could consider is having it open in a modal. I'm not sure if that would be annoying or not based on how this element gets used in practice. Another variant of the modal approach is an Offcanvas element.

unhammer commented 1 year ago

In practice I'm guessing people would set the stuff once (with perhaps a tiny bit of later tweaking) and once set they probably won't touch it much again. But when setting it they need to hunt-and-peck through 100 entries. So a bit like typical Preferences menus :) Offcanvas would probably be nice here, giving the list more space on the screen, possibly allowing for category-grouping (and on desktop has the added benefit over modal of letting you immediately see the changes in the output, though that's not a must-have)