Closed mpQadir closed 1 year ago
Totals | |
---|---|
Change from base Build 4398888430: | 0.004% |
Covered Lines: | 1380 |
Relevant Lines: | 1395 |
Please, fix, remove duplicate and merge.
On Thu, Mar 2, 2023, 10:55 PM Sushain Cherivirala @.***> wrote:
@.**** requested changes on this pull request.
Thanks! Let's add skr to https://github.com/apertium/apertium-html-tools/blob/master/src/strings/locales.json and add the changes of running make in https://github.com/apertium/apertium-html-tools/tree/master/src/strings.
In src/strings/skr.json https://github.com/apertium/apertium-html-tools/pull/459#discussion_r1123512120 :
@@ -0,0 +1,67 @@ +{
- @.***": {
- "authors": [
- "sushain97"
update this?
In src/strings/skr.json https://github.com/apertium/apertium-html-tools/pull/459#discussion_r1123512265 :
@@ -0,0 +1,67 @@ +{
- @.***": {
- "authors": [
- "sushain97"
- ],
- "last-updated": "2023-03-02",
- "locale": [
- "skr",
- "skr"
let's remove the duplicate here?
— Reply to this email directly, view it on GitHub https://github.com/apertium/apertium-html-tools/pull/459#pullrequestreview-1322342850, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXPYAW4B25OPXC3ZB6TKOP3W2DNI5ANCNFSM6AAAAAAVNSB4EA . You are receiving this because you authored the thread.Message ID: @.***>
@mpQadir is there someone in the community that can vouch for these translations? I unfortunately cannot properly review them.
https://github.com/apertium/apertium-html-tools/pull/460 should be combined into this PR.
@mpQadir is there someone in the community that can vouch for these translations? I unfortunately cannot properly review them.
@meesumalam could you take a look at these?
@mpQadir is there someone in the community that can vouch for these translations? I unfortunately cannot properly review them.
@meesumalam could you take a look at these?
Yes, I can.
@SaudQadir may verify these.
@mpQadir is there someone in the community that can vouch for these translations? I unfortunately cannot properly review them.
@meesumalam could you take a look at these?
Yes, I can.
@SaudQadir may verify these.
@mpQadir is there someone in the community that can vouch for these translations? I unfortunately cannot properly review them.
@meesumalam could you take a look at these?
Yes, I can.
I am Saraiki native, and I verify that the above translation is correct. and recommended for merge, please.
Add Saraiki language