apertium / apertium-html-tools

Web application providing a fully localised interface for text/website/document translation, analysis and generation powered by Apertium.
http://wiki.apertium.org/wiki/Apertium-html-tools
GNU General Public License v3.0
39 stars 90 forks source link

Google Summer of code in the about section behaves as a link #462

Closed 456535688765 closed 1 year ago

456535688765 commented 1 year ago

What Happens: The Google summer of code acts like a link instead of staying unchanged. while hovering it changes its state and it gets underlined

Solution : need some changes in the img section

TinoDidriksen commented 1 year ago

The actual bug is that https://summerofcode.withgoogle.com/static/img/summer-of-code-logo.svg is now a 404.

Could replace it with https://summerofcode.withgoogle.com/assets/media/logo.svg though depending on 3rd party images is a bad idea.

456535688765 commented 1 year ago

should I replace it with https://summerofcode.withgoogle.com/assets/media/logo.svg this image

TinoDidriksen commented 1 year ago

Looks like other assets are in https://github.com/apertium/apertium-html-tools/tree/master/src/components/footer/img, so I'd say it should go there.

456535688765 commented 1 year ago

So do I make a change in the code base or need to upload the image file here https://github.com/apertium/apertium-html-tools/tree/master/src/components/footer/img

456535688765 commented 1 year ago

Ok Got it Adding the Google summer of code img to this section https://github.com/apertium/apertium-html-tools/tree/master/src/components/footer/img

456535688765 commented 1 year ago

Sharing the PR Thank you @TinoDidriksen for your help

456535688765 commented 1 year ago

Hey @TinoDidriksen can you help me with the merging process

456535688765 commented 1 year ago

Thhe issue is not solved yet @hazemk537 Screenshot (230)

hazemk537 commented 1 year ago

@456535688765 we can do it inshaallah

456535688765 commented 1 year ago

I have resolved this Google Summer of code in the about section behaves as a link #462 problem but getting issues with the formatting of the code

456535688765 commented 1 year ago

Can you help me @TinoDidriksen?

456535688765 commented 1 year ago

Screenshot (232) resolved

456535688765 commented 1 year ago

should I start with the PR

TinoDidriksen commented 1 year ago

Yes, I don't know why you closed the PR.

456535688765 commented 1 year ago

I added some modules by mistake

hazemk537 commented 1 year ago