issue#462 about section

[hazemk537]

Because , I found an error while building when I used the SVG version , so I convert it to PNG

[coveralls]

Pull Request Test Coverage Report for Build 4459651220

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.003%) to 97.639%

---

Totals
Change from base Build 4398888430:	0.003%
Covered Lines:	1379
Relevant Lines:	1394

---

💛 - Coveralls

[sushain97]

If you run into an unexpected issue, please ask for help with it rather than reverting to a sub-optimal choice. In this case, you'll need to modify Jest config, ESBuild config and TS declarations to allow for SVG files.

[hazemk537]

okay , I can do that

[hazemk537]

1. I modified jest config after adding "^.+\.svg$": "jest-svg-transformer" to transformer
2. I added svg.d.ts for the svg module 3.should i install esbuild-plugin-svg and use it ? it is deprecated

[sushain97]

Please do not add any new config files or new dependencies. The existing support for gif/png files should extend to svg files immediately.

[hazemk537]

the svg is still not work,any help?

[hazemk537]

After many tries

• I cannot see the svg file in the dist folder .
• I searched and found that
  1. The esbuild built-in loader support s GIF , PNG and JPEG and donot support SVG.
  2. but If you want to load SVG files ,You should use extension like esbuild-plugin-svg
  3. so Its up to you !

References

If you want to load PNG, JPEG or GIF files as data URLs in your JavaScript code, you can use esbuild’s built-in loader option

If you want to load SVG files as strings or custom elements in your JavaScript code, you can use esbuild-plugin-svg

[TinoDidriksen]

We do NOT want any of the images as data URLs. But surely it can't be true that we need something special to copy an asset from the source to the build folder and insert the relative path to it.

[hazemk537]

okay , should I repo the repo to PNG version ? to accept the pull request ?

[TinoDidriksen]

No, the SVG version is correct. It should simply be handled same as the other images are - which is, copied to the build folder and linked from there.

[hazemk537]

No need to copy to dist , its working now using the SVG !!

[hazemk537]

Done

[sushain97]

Please fix the build failures.

[hazemk537]

done

[sushain97]

I don't think we should be increasing the test timeout. It's probably just flaky? Another run will fix it.

[hazemk537]

I tried runnibg it using jest and without increasing the timeout ,one file sometimes fails but after the increasing , no fails . I think we shoud increase it for future non fake issues during build . do you agrre with me ?

[sushain97]

No, we should fix the test to not flake instead.

[hazemk537]

so the problem is inside the test file itself ! I got it