Closed satti-hari-krishna-reddy closed 6 months ago
@sushain97 could you please review my changes? Your feedback would be highly appreciated.
Totals | |
---|---|
Change from base Build 7013115272: | 0.0% |
Covered Lines: | 1380 |
Relevant Lines: | 1395 |
@sushain97 sorry for late reply college work has been busy, Sure, I'll update the version in package.json field to actually match the latest released git hub version but i got a doubt , Since we're moving away from direct reliance on Git ,will manual updates to package.json be required for every release?
...will manual updates to package.json be required for every release?
Yes. That is the point. It's about what the source of truth is, and I hold that it should be the code - GitHub is merely storage, and must not be an integral part of the project.
Since we're moving away from direct reliance on Git ,will manual updates to package.json be required for every release?
Yes, this is fine. Ideally, we set up a GH workflow to create a tag and it'll fail when the tag already exists and succeed when a commit is pushed to master
with a new tag.
Yes. That is the point. It's about what the source of truth is, and I hold that it should be the code - GitHub is merely storage, and must not be an integral part of the project.
I don't disagree with this but I'd argue GitHub isn't relevant here. The tags are a Git construct which is arguably part of the source of truth. The point that a build shouldn't require .git
is one I agree with though so this is fine in general.
Hey @sushain97 , @TinoDidriksen , I've made some changes to the code. Can you take a look and let me know if everything's good now? Thanks!
@satti-hari-krishna-reddy CI is failing.
@sushain97 , I've got the Prettier error fixed, so the CI should be good to go now!
fixes #477
Description :
This pull request addresses the issue where the build process was relying on Git for version information. The problem arose when the build process did not have Git available.
Changes Made :
-In package.json, updated the
version
field to the latest released GitHub version-In build.ts, modified the code to use the version specified in package.json.