Closed satti-hari-krishna-reddy closed 8 months ago
hi @sushain97 , could you please review my pull request? : )
Totals | |
---|---|
Change from base Build 7236760780: | 0.005% |
Covered Lines: | 1382 |
Relevant Lines: | 1397 |
I've implemented the changes utilizing configContext. However, I'm uncertain if i did this in a correct way. Please review and provide feedback when you have a moment.
Description: This PR addresses issue #361 and also builds upon and supersedes the changes proposed in PR #422.
Changes Made:
config.ts
by addingshowMoreLanguagesLink
and specified its type asboolean
intypes.ts
. Also, addedmore_languages
tostringReplacements
.AboutModal.tsx
by conditionally renderingmore_languages
based on the value ofshouldDisplayString
, either true or false.index.test.tsx
, modified a test to check if, when the About dialog is opened andshowMoreLanguagesLink
is set totrue
, it should render themore_languages
. Similarly, whenshowMoreLanguagesLink
is set tofalse
and the About dialog is opened, it should not render themore_languages
.