modified " help us improve" link

[satti-hari-krishna-reddy]

reference #405

the version number just below help us improve link is actually directing to https://github.com/apertium/apertium-html-tools but i think many users wont even recognise that it is a clickable tag , most of them click on help us improve ,but that is opening AboutModal instead which isnt that helpful to report any issues .

[satti-hari-krishna-reddy]

in eng.json <a data-toggle='modal' data-target='#contactModal' data-text='Help_Improve' data-keyboard='true' data-dismiss='modal' style='cursor: pointer'>contact us</a> this is trying to trigger the contact modal when clicked on it but ,when we clicked on it nothing is happening . iam not sure why but i believe that there is no element with id contactModal in the dom is the reason why contactModal is not getting opened ?

[satti-hari-krishna-reddy]

to make things simple i made contact us to direct to https://wiki.apertium.org/wiki/Contact

[satti-hari-krishna-reddy]

@sushain97

what are your thoughts on this , does these changes make sense ?

[sushain97]

I don't really think it makes sense to have the version number open an 'About Apertium' modal... I'd see what @unhammer thinks though since he opened the initial ticket.

[satti-hari-krishna-reddy]

Ayo, my bad on the confusion in my pull request. It looks like there was a bit of a mix-up in understanding my changes. I should've explained things better. Let me give you a clearer picture:

Before

• Help us improve link is opening AboutModal .There is a link under "contact us", but it's the same colour as the other text and also the link is not working when clicked.
• the version number just below Help us improve is an anchor tag directing to https://github.com/apertium/apertium-html-tools when clicked.

After

• in the AboutModal the "contact us " link is now visible and direct users to https://wiki.apertium.org/wiki/Contact
• instead of opening AboutModal now help us improve will direct users to https://github.com/apertium/apertium-html-tools

[unhammer]

Having "contact us" goto wiki/contact is an improvement.

But I wouldn't want "Help us improve" to go to html-tools – typically people have suggestions for translation improvements. A better (but still not ideal) link would be https://wiki.apertium.org/wiki/Contributing

---

A better solution might be to send them to the issues page of the language pair they're currently looking at, e.g. if I'm at https://apertium.org/index.html#?dir=spa-cat&q=Mi%20aerodeslizador%20est%C3%A1%20lleno%20de%20anguilas and want to improve the translation, then I should get sent to

https://github.com/apertium/apertium-spa-cat/issues/new?title=Suggested+translation+improvement&body=SOURCE:%20Mi%20aerodeslizador%20est%C3%A1%20lleno%20de%20anguilas%0A%0AGOT:%20El%20meu%20aerolliscador%20est%C3%A0%20ple%20d%27anguiles%0A%0AEXPECTED:%20[YOUR%20TRANSLATION%20SUGGESTION%20GOES%20HERE]

(try that link that to see what it looks like, c.f. https://stackoverflow.com/a/34147022 we might want labels too)

[coveralls]

Pull Request Test Coverage Report for Build 8222512008

Details

• 27 of 28 (96.43%) changed or added relevant lines in 5 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.08%) to 97.566%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/util/initialTextValues.tsx	13	14	92.86%
<!--	Total:	27	28	96.43%	-->

Files with Coverage Reduction	New Missed Lines	%
src/components/footer/index.tsx	1	98.28%
<!--	Total:	1		-->

Totals
Change from base Build 8032731524:	-0.08%
Covered Lines:	1401
Relevant Lines:	1418

---

💛 - Coveralls

[satti-hari-krishna-reddy]

hey iam back , college work has been busy

[satti-hari-krishna-reddy]

i implemented the changes and they are working as expected

iam at https://8000-sattiharikr-apertiumhtm-fim4mxfdvou.ws-us108.gitpod.io/index.eng.html#?dir=eng-kir&q=cool

when i clicked on help us improve link it got sent to :

https://github.com/apertium/apertium-eng-kir/issues/new?title=Suggested+translation+improvement&body=SOURCE:%20cool%0A%0AGOT:%20%D1%81%D0%B0%D0%BB%D0%BA%D1%8B%D0%BD%0A%0AEXPECTED:%20%20%5BYOUR%20TRANSLATION%20SUGGESTION%20GOES%20HERE%5D

[satti-hari-krishna-reddy]

@sushain97, I've worked on bringing tgtText and srcText into the Footer component to achieve what unhammer suggested. It's also related to #482, and I need your help figuring out the best way. While attempting with React Context, I couldn't find the right way to fit it into the current code, so I created a new file. Also, due to changes in the help_improve button, tests checking that behavior have been removed for now. Any thoughts on the best approach would be super helpful.

[sushain97]

Let's first resolve the merge conflicts that now exist.

[satti-hari-krishna-reddy]

closing this and continuing at #498