Added dividers between languages

apertium / apertium-html-tools

Web application providing a fully localised interface for text/website/document translation, analysis and generation powered by Apertium.

http://wiki.apertium.org/wiki/Apertium-html-tools

GNU General Public License v3.0

41 stars 89 forks source link

Added dividers between languages #497

Open nrakhay opened 3 months ago

nrakhay commented 3 months ago

Hello!

This is my solution to the Issue #441 I tried both options proposed by Jonathan and,

I think we should go with adding a divider between languages as it looks cleaner and clearer. Below is the screenshot for this solution

However, I think you should also take a look at how solution with divider looks like:

nrakhay commented 3 months ago

Also, I could not make it to creating an account inside the Appertium Wiki and MediaWiki (the latter says incorrect captcha although it is 100% correct).

Is there any other way of creating it with the help of mentors?

@jonorthwash

nrakhay commented 3 months ago

I returned things how they were on the DOM level and added a divider using :after in CSS

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 8392470054

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.644%

Totals
Change from base Build 8354222802:	0.0%
Covered Lines:	1381
Relevant Lines:	1396

💛 - Coveralls

jonorthwash commented 3 months ago

The dividers separating varieties (e.g., for Occitan, Panjabi, etc.) should be different from those separating languages.

I don't totally love separators, but I agree that something would be nice here. It doesn't look as clean, even though it is clearer. How does Google (or other bigger site) deal with this problem?