setup.py for apertium python library

[coveralls]

Pull Request Test Coverage Report for Build 243

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 80.441%

---

Totals
Change from base Build 240:	0.0%
Covered Lines:	584
Relevant Lines:	726

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 241

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 80.441%

---

Totals
Change from base Build 240:	0.0%
Covered Lines:	584
Relevant Lines:	726

---

💛 - Coveralls

[sushain97]

Thanks for the RR! This doesn't actually install Apertium itself which is the tricky part of this :)

[jamessandy]

Okay,thanks. will get back to work on it

On Tue, Mar 5, 2019 at 9:35 PM Sushain Cherivirala notifications@github.com wrote:

Thanks for the RR! This doesn't actually install Apertium itself which is the tricky part of this :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/apertium/apertium-python/pull/37#issuecomment-469866731, or mute the thread https://github.com/notifications/unsubscribe-auth/AgC_oIuVa6BlWAaZrUqilRYpr_7NPDFqks5vTuMYgaJpZM4bfiUI .

[jamessandy]

if i am clear, am suppose to write a script to install apertium module ?

[sushain97]

There's an attempt to do that in this PR: https://github.com/apertium/apertium-python/pull/33. However, it needs to be cleaned up and integrated with the setup.py/pip workflow.

[jamessandy]

okay, i guess am to make the PR #33 installable in windows?

[sushain97]

That PR already does the install on Windows. It needs to be integrated into setup.py/pip. A user shouldn't have to run an extra script to finish the install. The script also needs to be cleaned up.

[jamessandy]

please where is the setup.py file ?

[sushain97]

You created a setup.py file in this PR. There isn't an existing one AFAIK.

[jamessandy]

Hello @sushain97 am done with this, this is the link to the package https://pypi.org/manage/project/apertium-app/releases/ and you can install with >> pip install apertium-app . Please need your review and comment.

[sushain97]

This doesn't handle any of the Windows installation steps. My comments above are unchanged.

[jamessandy]

please @sushain97 can you clear me up on this, i think am confused now

[sushain97]

I'm not sure where the confusion is coming from. This setup.py does not handle installation of Apertium itself. It only handles the installation of this API. Installing the API via setup.py should also install Apertium -- that is the entire purpose.

The setup.py file here is also missing a large number of important fields. See https://github.com/apertium/streamparser/blob/master/setup.py for a good example.

[jamessandy]

thanks, i think i know have an idea of what you're talking about, back to work

[jamessandy]

if i'm correct i'm expected to make apertium installable via windows command prompt?

[sushain97]

Not exactly. That's what the script in the other PR does. We want setup.py to run Python that installs Apertium.

[jamessandy]

Hello @sushain97 i am done with the new setup.py file for windows should i create a new pull request ?

[sushain97]

No, it should go here.

[jamessandy]

i should commit a change or just paste the code here ?

[sushain97]

Commit is preferable.

[jamessandy]

@sushain97 am done

[sushain97]

This does not install apertium core, it only installs the python package here.

[jamessandy]

i really don't understand anymore

[jamessandy]

you want a .exe file type for windows ?

[sushain97]

No. Have you looked at this PR: https://github.com/apertium/apertium-python/pull/33 ? Also, this wiki page: http://wiki.apertium.org/wiki/Installation.

[jamessandy]

Hello @sushain97 can I be pleased cleared, I'm to write a setup.py script to install Apertium from the Apertium repo on the coding challenge page. Is there something am doing wrong like the setup script or something am not doing. In my local machine I have built it and it's in an exe file for Windows and has a distro for Ubuntu and I have also put it up on pypi. Please clarify me so I can finish up😊😊 thanks and anticipating a rrpy soon

[sushain97]

This script only installs this Apertium Python library. It does not install Apertium itself.

[jamessandy]

@sushain97 is apertium itself contained in this repo ? https://github.com/apertium/apertium-python/

[sushain97]

No. It's contained in https://github.com/apertium/apertium. Did you look at my links above?

[jamessandy]

thanks sensei, just figured out where the issue is from..... back to work

[jamessandy]

@sushain97 i have made changes

[sushain97]

Changing the URL in the setup.py doesn't do anything... That URL is just for documentation.

[jamessandy]

Then what exactly is the issue ?

[sushain97]

I've said the issue multiple times above. Have you read the links I've provided regarding the installation of Apertium itself? Apertium core itself is not a Python package, it's C++.

[jamessandy]

hello @sushain97 last question for now.. can i uses pipenv for this issue ?

[sushain97]

Sure. That shouldn't really be relevant here.

[jamessandy]

Ok. So what's your advice ?

On Tue, Mar 19, 2019, 22:41 Sushain Cherivirala notifications@github.com wrote:

Sure. That shouldn't really be relevant here.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/apertium/apertium-python/pull/37#issuecomment-474595689, or mute the thread https://github.com/notifications/unsubscribe-auth/AgC_oON5c2n-wcZVzMJaJaoN6Q_r90A6ks5vYVl7gaJpZM4bfiUI .

[sushain97]

On what exactly?