search

apertium / apertium-python

now you can even use apertium from python
GNU General Public License v3.0
31 stars 27 forks source link

Don't build wrappers in travis/conda/etc. #47

Closed sushain97 closed 5 years ago

sushain97 commented 5 years ago

i.e. remove build-swig-wrapper.sh. I think the best way to accomplish this is via hosting each of the wrappers on PyPi. 

TinoDidriksen: [13:19:07] sushain, it's not my decision. Debian/Ubuntu/etc Python packages MUST install to dist-packages. If Travis is using a newer 3rd party Python, it's just not my problem.
[1:24pm] TinoDidriksen: [13:21:01] That's why it's so important to be compatible with what the distro provides. As soon as you deviate, you risk needing to pull in the whole damn build tree.
[1:24pm] ***: Playback Complete.
[1:24pm] sushain: TinoDidriksen: ah, okay
[1:24pm] sushain: in that case, we can hack for travis
[1:24pm] sushain: thanks for elaboarting
[1:24pm] sushain: elaborating*
[1:25pm] sushain: vaydheesh8: ^ can you add dist-packages to the python path on travis? should be an easy change
[1:25pm] sushain: we should also make pip install apertium do the apt-get steps on ubuntu/debian
[1:26pm] sushain: https://github.com/apertium/apertium-python/issues/55
[1:26pm] begiak: [ Automatic installation of apt deps on Ubuntu setup.py · Issue #55 · apertium/apertium-python · GitHub ]
[1:26pm] TinoDidriksen: Easy change, but will it be compatible? The distro Python 3 version is likely older than the one Travis added.
[1:27pm] sushain: oh argh
[1:27pm] sushain: let’s see…
[1:29pm] sushain: well, if it is the case that the distro version and travis version are separate, then the only solution I see is also distributing the wrappers via pypi/pip
[1:30pm] sushain: (aside from asking people to build their own stuff)
[1:30pm] sushain: is there another way?
[1:32pm] sushain: > The CI Environment uses separate virtualenv instances for each Python version. This means that as soon as you specify language: python in .travis.yml your tests will run inside a virtualenv (without you having to explicitly create it). System Python is not used and should not be relied on. If you need to install Python packages, do it via pip and not apt.
[1:32pm] sushain: boo.
[1:33pm] sushain: https://docs.travis-ci.com/user/languages/python/#travis-ci-uses-isolated-virtualenvs
[1:33pm] begiak: [ Building a Python Project - Travis CI ]
[1:36pm] sushain: TinoDidriksen: if we added a setup.py deploy target could you run that at the end of these builds?
[1:36pm] sushain: then people have the apt option if they want to use system python
[1:36pm] sushain: or the pip option if they want to use conda or another one of the many python environment things
singh-lokendra commented 5 years ago

This can be closed, right?