Added apertium-core - Githubissues

apertium / apertium-python

now you can even use apertium from python

GNU General Public License v3.0

31 stars 27 forks source link

Added apertium-core #53

Closed singh-lokendra closed 5 years ago

singh-lokendra commented 5 years ago

Wrapper for
1. apertium-interchunk
2. apertium-postchunk
3. apertium-transfer
4. apertium-pretransfer
Fix #43 & #50
Travis fails the build if mypy coverage <95, temporarily changed to 90

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 312

46 of 49 (93.88%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.6%) to 73.698%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
apertium/utils.py	43	46	93.48%
<!--	Total:	46	49	93.88%	-->

Totals
Change from base Build 301:	-1.6%
Covered Lines:	1939
Relevant Lines:	2631

Pull Request Test Coverage Report for Build 306

46 of 49 (93.88%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.6%) to 73.698%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
apertium/utils.py	43	46	93.48%
<!--	Total:	46	49	93.88%	-->

Totals
Change from base Build 301:	-1.6%
Covered Lines:	1939
Relevant Lines:	2631

Pull Request Test Coverage Report for Build 306

46 of 49 (93.88%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.6%) to 73.698%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
apertium/utils.py	43	46	93.48%
<!--	Total:	46	49	93.88%	-->

Totals
Change from base Build 301:	-1.6%
Covered Lines:	1939
Relevant Lines:	2631

💛 - Coveralls

sushain97 commented 5 years ago

We should uninstall the wrappers and re-run the tests to make sure the fallbacks work. Could you do that here or open an issue for it?

singh-lokendra commented 5 years ago

The subprocess call is working on appveyor https://ci.appveyor.com/project/sushain97/apertium-python/builds/25755769/job/sx0oreu75t67vq9l#L210 lrx-proc is expecting some input hence failing the build

sushain97 commented 5 years ago

That isn't enough long term, especially when the wrappers work on Windows. It needs to be tested separately. Fundamentally, code that doesn't get tested on each change will become outdated and broken.

singh-lokendra commented 5 years ago

Can we call python setup.py test before executing build-swig-wrapper.sh in before-script part of travis config

sushain97 commented 5 years ago

That works now but it still doesn't work long term because eventually the apt-get itself will install the wrappers, no?

singh-lokendra commented 5 years ago

The wrapper installation path is different according to python version /home/travis/virtualenv/python3.5.6/lib/python3.5/site-packages for python 3.5, so removing the files directly seems a bit tricky. The wrapper script should be easily removable when installed via pip or apt-get. Then we can re-run the tests to ensure all the tests are passing successfuly

sushain97 commented 5 years ago

That sounds good to me. Just open an issue for it so we can keep track of it!