search

apertium / apertium-python

now you can even use apertium from python
GNU General Public License v3.0
31 stars 27 forks source link

Updated documentation #65

Closed singh-lokendra closed 5 years ago

singh-lokendra commented 5 years ago
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 498

Totals Coverage Status
Change from base Build 463: -0.9%
Covered Lines: 1723
Relevant Lines: 2234
💛 - Coveralls
ftyers commented 5 years ago

Just an aside: Should it be apertium-python or python-apertium? Most packages I see in Debian are python-....

sushain97 commented 5 years ago

Uh, it should be neither. It should just be apertium on pip. Anything else is entirely redundant.

edit: not sure you were referring to pip but the README above is wrong

sushain97 commented 5 years ago

As for Debian, I don't care much since I wouldn't use it :)

singh-lokendra commented 5 years ago

I don't know why, but the apt-get install is returning exit code 100, even after installing apt-transport-https. https://travis-ci.com/apertium/apertium-python/builds/125114987

https://travis-ci.com/apertium/apertium-python/builds/125094062 https://travis-ci.com/apertium/apertium-python/builds/125109465

sushain97 commented 5 years ago

I think it was an intermittent issue? You might be able to revert the other commit now.

singh-lokendra commented 5 years ago

Should I the retry the installation process before exiting?

sushain97 commented 5 years ago

Hmmm, not sure what you mean?

singh-lokendra commented 5 years ago

Retry https://github.com/apertium/apertium-python/blob/master/apertium/installer.py#L113-L115, if return code isn't 0

sushain97 commented 5 years ago

Nah, I don't think that should be our default.

sushain97 commented 5 years ago

Going to merge this so I can release to PyPi and let you bring in a different PR that addresses the remaining concerns.

sushain97 commented 5 years ago

Released @ https://pypi.org/project/apertium/ !

sushain97 commented 5 years ago

@Vaydheesh can you send a release announcement email to the mailing list saying that it's available for trying out in an alpha stage via pip install apertium and to file any suggestions/issues in the issue tracker on GitHub?