search

apertium / apertium-python

now you can even use apertium from python
GNU General Public License v3.0
31 stars 27 forks source link

Add multiple spellings #86

Open ftyers opened 4 years ago

ftyers commented 4 years ago

I keep doing analyse() instead of analyze() :(

juuz0 commented 4 years ago

Can I take this? Would I need to provide an alternative for the class name too (Analyzer) or just providing an alternative name for analyze (analyse) is enough?

b-thebest commented 4 years ago

Can I fix it ?

ftyers commented 4 years ago

@juuz0 I guess that would be better yep.

@b-thebest I don't know, you can try!

b-thebest commented 4 years ago

@ftyers I don't find occurance of analyse(), I think its already been done

mr-martian commented 4 years ago

@b-thebest that's the issue, the code currently has the american spelling (with a z) and it would be nice if it also had the spelling with an s.

b-thebest commented 4 years ago

@mr-martian So, we need to change occurance of "analyze" ==> "analyse" Is that so?

mr-martian commented 4 years ago

not simply replace we want both

mr-martian commented 4 years ago

that is, we want an alias for the function

juuz0 commented 4 years ago

just providing an alias for the analyze() function name would be easy tho, I did that a few days ago :/ but couldn't find a way to provide an alias to the Analyzer class :/

juuz0 commented 4 years ago

Hello, I just added a pull request to add the aliases for both Analyzer(Analyser) and analyze(analyse), could you please check? :)

max-keviv commented 3 years ago

@ftyers if the issue is not resolved can I work on this issue

TinoDidriksen commented 3 years ago

@max-keviv there is a PR https://github.com/apertium/apertium-python/pull/87 that I approved, but left a question on that never got answered. So only if you can find other interfaces in need of alternative spellings.