search

apertium / apertium-recursive

Recursive structural transfer module for Apertium
https://wiki.apertium.org/wiki/Apertium-recursive
GNU General Public License v3.0
6 stars 4 forks source link

reparse individual non-parsed words after full sentence #94

Closed unhammer closed 1 year ago

unhammer commented 1 year ago

as noted in https://github.com/apertium/apertium-recursive/issues/80#issuecomment-1691484763 this tries to do a reparse of single, unparsed words after full parse.

It seems to fix things in corpus runs.

Could it break anything @mr-martian ?

unhammer commented 1 year ago

ok so it breaks tests :) Is it an actual failure? a tag changed from pl to sg

mr-martian commented 1 year ago

In the first test that fails, there are 2 rules and they both change the same variable, and I think something might be going wrong with the ordering of those operations.

unhammer commented 1 year ago

OK so it seems all the tests run in processGLR, I thought xmls used processTRX (can we rename that function to processLinear or something?)

unhammer commented 1 year ago

Think I figured it out (didn't notice that checkForReduce changed currentBranch), tests pass now. @mr-martian does it seem OK to merge?