Open unhammer opened 3 years ago
Diff/Inserted/Deleted only makes sense for steps in red tabs. They should be disabled when on a blue tab.
Accept Result
accepts all steps, so this button is usable on all tabs.
All 3 Gold buttons are needed, but you're right they're not all needed all the time. If there is no gold, then only Add As
and Add New
are needed. The Replace
button only makes sense if there are golds. Add New
is the manual input from https://github.com/apertium/apertium-regtest/commit/59895ef5419f71fe40ff023552aeef9705b5c2fe
In general, I want all buttons to be on screen, but merely greyed out. It's jarring if buttons change position depending on what's available.
"doesn't say Output before the output" was intentional because the label takes up too much space normally, but when there are golds then it makes sense to show it.
But yes, this needs more documentation.
It's jarring if buttons change position depending on what's available.
Sure, that makes it easier to quickly click things. I think the grey could be greyer though (I had to try hovering over "accept: generator" before I convinced myself it wasn't clickable).
copy-pasting irc for posterity:
Unhammer> I had no idea "Add new" was in input form. Hm, I read it as "add this output as a new gold" [11:21] TinoDidriksen> Could rename that "Manual Gold". Unhammer> perhaps with a ↓ or ▼ or something to show that a popup appears
the grey could be greyer
Sure, can do that. In addition to marking them disabled, we can change the base color to btn-outline-secondary
I think I did most of the things discussed here. @unhammer did I miss anything?
Looks much better =D
I do think some help text at the top would be nice too, but I'm not sure what it should say. (Some kind of friendly intro to how to use it.)
I also just learnt what the diff/inserted/deleted buttons do. Since at most one works at a time, I think maybe they should be styled in a way that shows that (traditionally that'd be radio buttons, but maybe there's a bootstrappier way to do that IANADesigner)
The accept button is still confusing for me....
It says accept all except the entire output: why is that? what if I want all (including the entire output) to be accepted?
That's a typo. accept
sounds like except
, and it should be accept
Nothing happens when I click Diff/Inserted/Deleted – when are they supposed to do anything? There is a diff between output and gold.
Also, especially when looking at Generator output, it's a bit confusing that the second line there actually is the generator output (gold and input are labelled, but it doesn't say Output before the output).
And why are there three "Replace as gold", "Add as gold" and "Add new gold" – why isn't "Replace as gold" and "Add new gold" enough? (If there isn't a gold already, perhaps s/Replace/Add.)
I can see that generator is accepted because I can't press the button, but what then does
Accept result
do?Could perhaps have a little tutorial thing at the top of the screen.