search

apertium / apertium

Core tools (driver script, transfer, tagger, formatters) for the FOSS RBMT system Apertium
https://apertium.org/
GNU General Public License v2.0
92 stars 26 forks source link

Configure script should check for svn #36

Closed ftyers closed 4 years ago

ftyers commented 5 years ago

I just installed a new laptop and tried to compile Apertium and got the following error:

svn checkout https://github.com/unhammer/apertium-get/trunk apertium-get
/bin/bash: svn: no s'ha trobat l'ordre
Makefile:1716: recipe for target 'apertium-get/apertium-get' failed
make[2]: *** [apertium-get/apertium-get] Error 127
make[2]: Leaving directory '/home/fran/source/apertium/trunk/apertium/apertium'
Makefile:938: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/home/fran/source/apertium/trunk/apertium/apertium'
Makefile:484: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
Making install in apertium
make[1]: Entering directory '/home/fran/source/apertium/trunk/apertium/apertium'
svn checkout https://github.com/unhammer/apertium-get/trunk apertium-get
/bin/bash: svn: no s'ha trobat l'ordre
Makefile:1716: recipe for target 'apertium-get/apertium-get' failed
make[1]: *** [apertium-get/apertium-get] Error 127
make[1]: Leaving directory '/home/fran/source/apertium/trunk/apertium/apertium'
Makefile:484: recipe for target 'install-recursive' failed
make: *** [install-recursive] Error 1
flammie commented 5 years ago

I thought I already made a bug of this but apparently not... I would recommend a solution not needing svn, it's quite a pita for package maintenance to have svn checkout as a part of a build.

unhammer commented 5 years ago

apertium-get is https://github.com/apertium/apertium-get/

Maybe it shouldn't be part of apertium at all? @TinoDidriksen is it still easy to have it part of the Debian apertium-all-dev if it's not a part of this repo? IIRC you did something like that with apertium-eval-translator

TinoDidriksen commented 5 years ago

Currently it is a git submodule and won't try to use svn if you init submodules during/after cloning.

But sure, we can split it into a completely separate package and have -all-dev depend on that.

TinoDidriksen commented 5 years ago

https://github.com/apertium/apertium/issues/4 would also be solved by making a clean separation.