search

apertium / lttoolbox

Finite state compiler, processor and helper tools used by apertium
http://wiki.apertium.org/wiki/Lttoolbox
GNU General Public License v2.0
18 stars 22 forks source link

configure.ac: fix bashism #171

Closed thesamesam closed 1 year ago

thesamesam commented 1 year ago

configure scripts need to be runnable with a POSIX-compliant /bin/sh.

On many (but not all!) systems, /bin/sh is provided by Bash, so errors like this aren't spotted. Notably Debian defaults to /bin/sh provided by dash which doesn't tolerate such bashisms as '=='.

This retains compatibility with bash.

Signed-off-by: Sam James sam@gentoo.org

TinoDidriksen commented 1 year ago

For such simple fixes, sure. Overall, Apertium requires that Bash is installed, even if it's not /bin/sh.

thesamesam commented 1 year ago

Yeah, that's no problem. It's a requirement specifically for configure just because of its shebang. I'm not looking to impose non-Bash requirements everywhere, indeed, Gentoo relies heavily on it.

It's purely about /bin/sh.

Thanks!