search

apertium / phenny

This is a port of phenny, a Python IRC bot, to Python3. This specific version, called begiak, is a fork of the Wadsworth version, used by the apertium project.
http://wiki.apertium.org/wiki/Begiak
Other
16 stars 42 forks source link

webhook received malformed payload not to channels #591

Open flammie opened 4 years ago

flammie commented 4 years ago

I think that the message:

08:34  begiak> Webhook received malformed payload

is not very useful for the people on channel and should probably be sent to admins directly instead or something.

kj7rrv commented 4 years ago

Good idea. Sometime I might rewrite my error logger to not use Flask, then we could add this to it.

On Wed, Aug 5, 2020, 06:05 Flammie Pirinen notifications@github.com wrote:

I think that the message:

08:34 begiak> Webhook received malformed payload

is not very useful for the people on channel and should probably be sent to admins directly instead or something.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apertium/phenny/issues/591, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN54XP2P3UJJPAOQLBI3ZNLR7FKJ5ANCNFSM4PVOQ6WQ .

kj7rrv commented 4 years ago

That message also makes it easy to make a spambot with a simple bash loop and curl command.

On Wed, Aug 5, 2020, 08:44 Samuel Sloniker scoopgracie@gmail.com wrote:

Good idea. Sometime I might rewrite my error logger to not use Flask, then we could add this to it.

On Wed, Aug 5, 2020, 06:05 Flammie Pirinen notifications@github.com wrote:

I think that the message:

08:34 begiak> Webhook received malformed payload

is not very useful for the people on channel and should probably be sent to admins directly instead or something.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apertium/phenny/issues/591, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN54XP2P3UJJPAOQLBI3ZNLR7FKJ5ANCNFSM4PVOQ6WQ .

unhammer commented 7 months ago

https://github.com/apertium/phenny/blob/6b15a463f050c6acbb205efd6d43a39ffffc9a08/modules/git.py#L136

seems simple to fix! but who's actually running begiak? @jonorthwash ?