search

apertureless / vue-chartjs

📊 Vue.js wrapper for Chart.js
https://vue-chartjs.org
MIT License
5.49k stars 831 forks source link

fix: update to chart.js v4.4.1 #1064

Closed mihai-peteu closed 6 months ago

mihai-peteu commented 6 months ago

Pulling in latest version of chart.js as a fix for https://github.com/apertureless/vue-chartjs/issues/1063

mihai-peteu commented 6 months ago
Screenshot 2023-12-07 at 6 30 06 AM

Other PRs seem to be failing with the same complaint. https://github.com/apertureless/vue-chartjs/actions/runs/7111433638

adamdehaven commented 6 months ago

@apertureless is this repo still maintained?

apertureless commented 6 months ago

@mihai-peteu Can you rebase? The CI should be fixed now.

mihai-peteu commented 6 months ago

@apertureless checks passed 🙌

mihai-peteu commented 6 months ago

Thanks!

Looks like the website workflow failed.

Does the release workflow need to be run manually? Would love to get this published to npm so we verify this fixes a bug we encountered.

apertureless commented 6 months ago

@mihai-peteu yeah, some pnpm shenanigans with the updated version. Not sure why this happens, as the lockfile should be updated.

The new version is released to npm.