search

apetavern / grubs

A worms-inspired artillery game for s&box with randomly generated levels.
MIT License
34 stars 7 forks source link

Fix arc projectiles exploding prematurely #266

Closed dch-GH closed 1 year ago

dch-GH commented 1 year ago

Fixes:#264

I'm not really a huge fan of this fix to be honest. It's not a catch-all. It might be more ideal to not have a capped segment count in the first place. Maybe a time limit instead? Anyway, the segment count was really low and those grubs can really yeet projectiles, so it was going insanely high but the segment count wasn't large enough and the projectile exploded early. The ArcPhysicsGadgetComponent defaulted to exploding the projectile regardless of its ExplodeAfter time.

trundlr commented 1 year ago

We have two options here imo:

  1. Calculate the minimum segments required and use that number
  2. Fall back to a standard PhysicsGadgetComponent when the ArcPhysics segments reach 0

I wanted to increase the segment count either way. I won't approve this right away but we can continue the discussion in the issue or on Discord.

dch-GH commented 1 year ago

We have two options here imo:

  1. Calculate the minimum segments required and use that number
  2. Fall back to a standard PhysicsGadgetComponent when the ArcPhysics segments reach 0

I wanted to increase the segment count either way. I won't approve this right away but we can continue the discussion in the issue or on Discord.

Sounds good. I'll explore both these options and follow up on Discord if I run into any issues.